Get IP fast in non-async examples #401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would it be better to have a bulletproof method of doing this, instead of relying on the order of calls? I guess we can track link state change in a similar way to embassy and then reset the DHCP socket within our stack? |
|
Yeah, was thinking about it - just felt a bit lazy but since you unmasked me, I will have a look 👍 |
|
Hehe, if it becomes a bunch of work then we can merge this as is, and open an issue for a more robust solution in the future. |
bjoernQ
force-pushed
the
improve-non-async-wifi-examples
branch
from
786b5d8 to
9876c9f
Compare
Turned out doing the right things wasn't that bad 😆 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I never experienced this with my old router but now getting the IP from DHCP takes multiple seconds for the non-async examples while it's blazing fast for the async examples.
Just changed the examples to construct the network stack after the connection to the AP is successful fixes that.
(basically, why embassy-net is so much faster is embassy-rs/embassy#2104 ... which explains why the changes here do the trick)