Avoid overwriting HCI buffer until sent #398
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When implementing an BLE HID device it turned out that for BTDM based drivers we shouldn't touch the packet passed to
API_vhci_host_send_packet
until it's sentAPI_vhci_host_check_send_available
doesn't seem to be suitable for that - for an easy fix this uses thenotify_host_send_available
callback to toggle a flag which seems to fix the issueNPL based drivers seem to copy the packet in their send function and are not affected
If this ever turns out to become a performance problem, we can implement something more advanced but for now it seems to be good enough