Minor updates #139
Minor updates #139
Conversation
|
I think it will cause problems with Really hope our dependencies get a release and we are able to release |
|
Hopefully we will have a enet release soon: embassy-rs/embassy#2401 then we can bump esp-wifi and merge this. |
|
embassy-net 0.3 is now available on crates.io so I think we can get things moving here! |
Awesome! I will update + release esp-wifi tomorrow |
| @@ -6,21 +6,31 @@ edition = "2021" | |||
| license = "MIT OR Apache-2.0" | |||
|
|
|||
| [dependencies] | |||
| hal = { package = "{{ mcu }}-hal", version = "{{ hal_version }}" } | |||
| {{ mcu }}-hal = "{{ hal_version }}" | |||
There was a problem hiding this comment.
What's the reason we don't want to alias the HAL dependency anymore?
There was a problem hiding this comment.
What was the reason we did it in the first place? I always found it weird and needless, every time I generated a template I changed it.
There was a problem hiding this comment.
Oh ... interesting. I found it to be easier to copy code around this way ... however, I don't have a hard preference. Was just curious - and also once we did the split, we will just have esp_hal or something
There was a problem hiding this comment.
I don't feel too strongly about this, so feel free to revert if anybody else does.
There was a problem hiding this comment.
I dont have any hard preference, tbh
There was a problem hiding this comment.
The main idea behind alias is to increase portability of the code. Using alias makes it easier to have common app code for multiple targets.
There was a problem hiding this comment.
The next release will unify the hal, meaning all hals will be exposed under esp_hal, just like esp_idf_hal supports all target in one.
Cargo.toml
Outdated
| smoltcp = { version = "0.11.0", default-features=false, features = ["proto-igmp", "proto-ipv4", "socket-tcp", "socket-icmp", "socket-udp", "medium-ethernet", "proto-dhcpv4", "socket-raw", "socket-dhcpv4"] } | ||
| embedded-svc = { version = "0.26.4", default-features = false, features = [] } | ||
| embedded-io = "0.6.1" | ||
| heapless = { version = "0.8.0", default-features = false } |
There was a problem hiding this comment.
I'm not sure we should bump this since it's mostly used for embedded-svc which is still on 0.7+
There was a problem hiding this comment.
oh sorry - we shouldn't downgrade embedded-io but heapless: https://crates.io/crates/embedded-svc/0.26.4/dependencies
Reason is, it's used in esp-wifi's (through embedded-svc) public API
There was a problem hiding this comment.
downgrading smoltcp is probably good since for some reason we forgot to bump it in esp-wifi 0.2.0 🤦♂️
There was a problem hiding this comment.
I think now, if I understood it correctly, dependencies should be fine.
SergioGasquez
force-pushed
the
fix/updates
branch
2 times, most recently
from
a58686c to
26766bb
Compare
SergioGasquez
force-pushed
the
fix/updates
branch
from
26766bb to
11160e9
Compare
verify.shnow exits on errorsSupersedes #135