Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recommend using cfg.toml instead of big-heap #22

Merged
merged 1 commit into from
Nov 29, 2023
Merged

Recommend using cfg.toml instead of big-heap #22

merged 1 commit into from
Nov 29, 2023

Conversation

bugadani
Copy link
Contributor

@bugadani bugadani commented Nov 29, 2023 •
edited
Loading

Companion PR of esp-rs/esp-wifi-sys#367

We can start recommending cfg.toml even before we remove big-heap (so I didn't change the esp-wifi rev).

@bugadani bugadani marked this pull request as ready for review November 29, 2023 07:09
AnthonyGrondin
AnthonyGrondin reviewed Nov 29, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
bjoernQ
bjoernQ approved these changes Nov 29, 2023
View reviewed changes
Copy link
Collaborator

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bjoernQ bjoernQ merged commit 749a0cc into esp-rs:main Nov 29, 2023
1 check failed
@bugadani bugadani deleted the heap branch November 29, 2023 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AnthonyGrondin AnthonyGrondin AnthonyGrondin left review comments

@bjoernQ bjoernQ bjoernQ approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bugadani @bjoernQ @AnthonyGrondin