Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the 64bit time_t flag when targeting v5 #65

Merged
merged 2 commits into from
Nov 1, 2022
Merged

Conversation

MabezDev
Copy link
Member

No description provided.

@MabezDev MabezDev requested a review from ivmarkov October 31, 2022 11:21
Copy link
Collaborator

@ivmarkov ivmarkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this change is OK. But given that ESP IDF 5 was already released, we might want to extend the esp-idf-template to support the 5.0 released version as well. And then the "if" for this flag would be a bit extended too.

Further on, we need to support this flag in the cmake-first build as well, but I guess this can be a separate PR.

@MabezDev
Copy link
Member Author

MabezDev commented Nov 1, 2022

Good points, will add cmake support and look at adding v5 support too.

@MabezDev MabezDev force-pushed the feature/v5-time-cfg branch from 64f8fe2 to 8bfdd9d Compare November 1, 2022 11:36
@MabezDev
Copy link
Member Author

MabezDev commented Nov 1, 2022

I don't think V5.0 is fully released yet, at least there is no tag or release on GitHub so will defer adding those options to another PR.

@ivmarkov
Copy link
Collaborator

ivmarkov commented Nov 1, 2022

Indeed there is no v5.0 tag, yet there is a release branch?
https://github.com/espressif/esp-idf/tree/release/v5.0

@ivmarkov
Copy link
Collaborator

ivmarkov commented Nov 1, 2022

@ivmarkov
Copy link
Collaborator

ivmarkov commented Nov 1, 2022

But I agree - this could be a separate PR.

@MabezDev
Copy link
Member Author

MabezDev commented Nov 1, 2022

https://docs.espressif.com/projects/esp-idf/en/release-v5.0/esp32/get-started/index.html

At the top of those docs says v5.0 is a pre release version, so I'll defer for now until its properly released.

@MabezDev MabezDev merged commit ed3e55f into master Nov 1, 2022
@ivmarkov ivmarkov deleted the feature/v5-time-cfg branch October 17, 2023 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants