Default to v4.4 #58
Closed
Default to v4.4 #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MabezDev
force-pushed
the
feature/default-v4.4
branch
from
9a72d48 to
2d88870
Compare
|
Thanks! I've accommodated bits and pieces of your PR here: 9d09145 That is, most of it except for not really switching to 4.4 as default (yet), as PlatformIO is still on 4.3. By the way, last night we were hit by PlatformIO releasing their "espressif32" "platform" with 4.3.2 support (previously it was 4.3.1) and the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sister PR: esp-rs/esp-idf-template#9
AFAIK we can't change the esp-idf version in esp-idf? Therefore I removed the patching for pio.
Marking as draft until pio v4.4 release.