Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement RTCIO pullup, pulldown and hold control for Xtensa MCUs #684

Merged
merged 1 commit into from
Aug 14, 2023

Conversation

bugadani
Copy link
Contributor

@bugadani bugadani commented Jul 25, 2023

No examples yet. The goal is to eventually implement GPIO wakeup sources which can configure pullups/pulldowns, and I expect an example to cover this functionality at that point.

Examples are part of #690

@bugadani bugadani force-pushed the pull branch 2 times, most recently from 63b86a7 to adbc009 Compare July 25, 2023 08:56
@bugadani bugadani marked this pull request as draft July 25, 2023 13:52
@bugadani bugadani force-pushed the pull branch 2 times, most recently from d3f3feb to d7a8b9c Compare July 25, 2023 13:58
@bugadani bugadani marked this pull request as ready for review July 25, 2023 14:02
@bugadani bugadani force-pushed the pull branch 5 times, most recently from 3794089 to 36787cc Compare August 2, 2023 14:06
@bugadani
Copy link
Contributor Author

bugadani commented Aug 8, 2023

@jessebraham I don't know if I should ping you or not, but I have to ask if this PR is in the queue or got lost due to me drafting it back-and-forth multiple times 😅

@bugadani bugadani force-pushed the pull branch 2 times, most recently from 2d6da33 to 58a2e28 Compare August 9, 2023 20:12
@bugadani bugadani mentioned this pull request Aug 10, 2023
@bugadani bugadani force-pushed the pull branch 2 times, most recently from 5126755 to 3180e19 Compare August 10, 2023 17:38
Copy link
Member

@jessebraham jessebraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@jessebraham jessebraham merged commit a2ae6f3 into esp-rs:main Aug 14, 2023
@bugadani bugadani deleted the pull branch August 14, 2023 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants