Async serial uart read #620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you address the remaining review comments from #615 here please. |
|
Sorry, you are right I lost some code on commit. I will put it back |
MabezDev
reviewed
Jun 26, 2023
MabezDev
approved these changes
Jun 26, 2023
There was a problem hiding this comment.
Thanks for sticking with me during the review process @alexiionescu, this is looking good now!
Could you fix the conflict in the changelog (sorry, I just merged another PR)?
SergioGasquez
pushed a commit
to SergioGasquez/esp-hal
that referenced
this pull request
Jun 28, 2023
* implement embassy async uart read * Add embassy async read support for uart * changes based on review * fix CI failures * change review #2 * fixed re-opened PR number * changes review no.3 --------- Co-authored-by: Scott Mabin <[email protected]>
MabezDev
added a commit
that referenced
this pull request
Jul 12, 2023
* implement embassy async uart read * Add embassy async read support for uart * changes based on review * fix CI failures * change review #2 * fixed re-opened PR number * changes review no.3 --------- Co-authored-by: Scott Mabin <[email protected]>
playfulFence
pushed a commit
to playfulFence/esp-hal
that referenced
this pull request
Sep 26, 2023
* implement embassy async uart read * Add embassy async read support for uart * changes based on review * fix CI failures * change review jessebraham#2 * fixed re-opened PR number * changes review no.3 --------- Co-authored-by: Scott Mabin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
serial uart
readforembassyasyncTested on ESP32C3 only.
NOTE:
embassy_hal_asyncdoes not have aReadtrait forserial,onlyWritetraits, so I could not follow the same implementation pattern as in the write case. The new function is calledread, not sure if it is Ok, there was not a read function for nb implementation. If you think is to generic, I can change it toread_asyncAlso fix an issue with async write on large buffers, was panicking with Err Would Block. Discovered when testing reading and echoing back a large reader buffer.
NOTE: this is a reopen of the #615 PR.
Must
errorsorwarnings.cargo fmtwas run.CHANGELOG.mdin the proper section.Nice to have