Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation links #3197

Merged
merged 2 commits into from
Mar 3, 2025
Merged

Conversation

SergioGasquez
Copy link
Member

Thank you for your contribution!

We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:

Submission Checklist 📝

  • I have updated existing examples or added new ones (if applicable).
  • I have used cargo xtask fmt-packages command to ensure that all changed code is formatted correctly.
  • My changes were added to the CHANGELOG.md in the proper section.
  • I have added necessary changes to user code to the Migration Guide.
  • My changes are in accordance to the esp-rs API guidelines

Extra:

Pull Request Details 📖

Description

Update links to https://docs.espressif.com/projects/rust/index.html and add the documentation field for the packages that didnt have it.

Testing

NA

@SergioGasquez SergioGasquez added the skip-changelog No changelog modification needed label Mar 3, 2025
@SergioGasquez
Copy link
Member Author

Maybe the documentation field of Cargo.toml should point to the latest version of that crate, but I couldn't find a direct link to it

@MabezDev
Copy link
Member

MabezDev commented Mar 3, 2025

Maybe the documentation field of Cargo.toml should point to the latest version of that crate, but I couldn't find a direct link to it

For now this is good enough, #3198 will make this better in the longer run.

Copy link
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MabezDev MabezDev added this pull request to the merge queue Mar 3, 2025
Merged via the queue into esp-rs:main with commit 3816de0 Mar 3, 2025
27 of 28 checks passed
@SergioGasquez SergioGasquez deleted the fix/doc-link branch March 3, 2025 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog No changelog modification needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants