Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide Interrupts #3152

Merged
merged 1 commit into from
Feb 19, 2025
Merged

Hide Interrupts #3152

merged 1 commit into from
Feb 19, 2025

Conversation

bugadani
Copy link
Contributor

Closes #2525 although in the laziest possible way.

@bugadani bugadani marked this pull request as ready for review February 19, 2025 14:01
MabezDev
MabezDev approved these changes Feb 19, 2025
View reviewed changes
Copy link
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we can choose how we want to expose this later (probably just a new type)

@JurajSadel JurajSadel added this pull request to the merge queue Feb 19, 2025
Merged via the queue into esp-rs:main with commit 26cf556 Feb 19, 2025
27 checks passed
@bugadani bugadani deleted the hide-pac branch February 19, 2025 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dominaezzz Dominaezzz Dominaezzz left review comments

@MabezDev MabezDev MabezDev approved these changes

@JurajSadel JurajSadel JurajSadel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ensure the PAC crates and other private crates are never exposed publicly
4 participants
@bugadani @MabezDev @Dominaezzz @JurajSadel