Adds check to guard against rcv frame panic issue #1862
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your contribution!
We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:
Submission Checklist 📝
cargo xtask fmt-packages
command to ensure that all changed code is formatted correctly.CHANGELOG.md
in the proper section.Extra:
Pull Request Details 📖
Adds a length check to avoid out-of-bounds access panic in the
RX_BUFFER
slice duringEvent::RxDone
event processing.Description
I have seen a rare bug pop up a two times now after leaving multiple esp32c6 devices running openthread (via the
esp-openthread
crate) for long periods of time :I view this PR addition as a temporary hold over. A more comprehensive fix is likely needed here or elsewhere (this crate, the
esp-openthread
crate, etc). Unfortunately I had no backtrace when the bug popped up the two times I saw it nor had anything else set up to assist in debugging. So need to work on reliable repro before digging in further. This bug only popped up twice over many days/hours of constant operation so will continue to monitor.Testing
Applied the fix and confirmed it builds and runs as expected using the
esp-openthread
crate. Have also verified the ieee802154 example bins still run as well.