Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the esp-println package to the repository #1575

Merged
merged 2 commits into from
May 23, 2024

Conversation

jessebraham
Copy link
Member

@jessebraham jessebraham commented May 22, 2024

No changes to the library itself were made. The build script was updated to use esp-build, however the behaviour remains the same.

I have not updated README.md at all other than fixing the paths to the license files, since this is used in the docs. This can be updated as needed in a subsequent PR.

A patch is temporarily required for the examples/ package, until esp-backtrace gets added as well; I will take care of all that once this PR is merged.

Once this is merged I will transfer any relevant issues and archive the old esp-println repository.

@jessebraham jessebraham added the skip-changelog No changelog modification needed label May 22, 2024
Copy link
Contributor

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks for taking care of this!

@bjoernQ
Copy link
Contributor

bjoernQ commented May 23, 2024

I'm wondering how we could best deal with CI in future?

I guess we could run CI for a crate only if something changed in the path but I'm not sure how that works with HIL tests

Copy link
Member

@SergioGasquez SergioGasquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Left one nitpick suggestion that can be ignored.

esp-println/README.md Outdated Show resolved Hide resolved
@SergioGasquez
Copy link
Member

I guess we could run CI for a crate only if something changed in the path but I'm not sure how that works with HIL tests

This would be very helpful, but we might need to do some tests, as the “required tests” feature of GH works weird.

@MabezDev
Copy link
Member

I guess we could run CI for a crate only if something changed in the path

Whilst I do like the idea in principle, I think simple is better. The main contributions to CI time are esp-hal (and will be esp-wifi too), the other crates compile in a few seconds usually. Happy to explore it if we can find a robust way to do it though.

Co-authored-by: Sergio Gasquez Arcos <[email protected]>
Copy link
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MabezDev MabezDev enabled auto-merge May 23, 2024 09:10
@MabezDev MabezDev disabled auto-merge May 23, 2024 09:18
@MabezDev
Copy link
Member

Hmm, new clippy lint 😫. I think I'm just gonna force merge this and we can deal with it in a different PR.

@MabezDev MabezDev merged commit cc28c3e into esp-rs:main May 23, 2024
21 of 22 checks passed
@jessebraham jessebraham deleted the feature/esp-println branch May 23, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog No changelog modification needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants