-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the esp-println
package to the repository
#1575
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - Thanks for taking care of this!
I'm wondering how we could best deal with CI in future? I guess we could run CI for a crate only if something changed in the path but I'm not sure how that works with HIL tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Left one nitpick suggestion that can be ignored.
This would be very helpful, but we might need to do some tests, as the “required tests” feature of GH works weird. |
Whilst I do like the idea in principle, I think simple is better. The main contributions to CI time are esp-hal (and will be esp-wifi too), the other crates compile in a few seconds usually. Happy to explore it if we can find a robust way to do it though. |
Co-authored-by: Sergio Gasquez Arcos <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Hmm, new clippy lint 😫. I think I'm just gonna force merge this and we can deal with it in a different PR. |
No changes to the library itself were made. The build script was updated to use
esp-build
, however the behaviour remains the same.I have not updated
README.md
at all other than fixing the paths to the license files, since this is used in the docs. This can be updated as needed in a subsequent PR.A patch is temporarily required for the
examples/
package, untilesp-backtrace
gets added as well; I will take care of all that once this PR is merged.Once this is merged I will transfer any relevant issues and archive the old
esp-println
repository.