Decouple the twai driver from the embedded-hal traits
#1355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjoernQ
approved these changes
Mar 28, 2024
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR decouples the
twaidriver from theembedded-haltraits, allowing it to be used without importing said traits. This unfortunately has resulted in a lot of duplication between our HAL and the twoembedded-halpackages, however I see no other way around this really.There are still some other changes to be made, but after another PR we should be able to build the HAL without either the
embedded-halorembedded-hal-02features enabled and still have it be usable.There is still some room for improvement with regards to documentation here, however I'm rather unfamiliar with the filters, etc. and don't really know how best to describe them. For this reason, I will leave the task to somebody more knowledgeable.