Update module documentation for UART driver, make some more methods public #1347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I guess when we take the effort to add more higher-quality examples in the docs we should really get #1095 to work. Would be a shame when those examples get outdated and won't compile anymore Just mentioning it ... I know we have a lot to do |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is probably still not "complete", there should probably be more information regarding additional functionality such as interrupts, async operation, etc., and some more examples maybe too. But, for now I think it's an improvement at least.
There were additionally a few methods gated behind the
embedded-halfeature; I thin these are actually useful to expose so have done so here, can revert that if there's a reason to though.