Add the esp-build package, update esp-hal and esp-lp-hal to use it in their build scripts
#1325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessebraham
commented
Mar 21, 2024
MabezDev
approved these changes
Mar 21, 2024
It's okay, I wrote them and I won't claim to understand them either 😂 (More seriously though, cargo-expand is your friend here!) |
yanshay
pushed a commit
to yanshay/esp-hal
that referenced
this pull request
Mar 25, 2024
… it in their build scripts (esp-rs#1325) * Create the `esp-build` package * Update `esp-hal` and `esp-lp-hal` to use `esp-build`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is probably still some room for improvement here, but my procmacro skills are lacking and as such it will probably take me some time to figure things out. So, figured I'd just open this in its current state and see what people think.
We've discussed this briefly a few times, but basically the idea is just to encapsulate the various pieces of build logic that we've been copy-pasting around our projects. I've also replaced the old declarative macros with procmacros which produce much nicer error output.