Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable TWAI for ESP32-C6 #1323

Merged
merged 5 commits into from
Mar 21, 2024
Merged

Enable TWAI for ESP32-C6 #1323

merged 5 commits into from
Mar 21, 2024

Conversation

bjoernQ
Copy link
Contributor

@bjoernQ bjoernQ commented Mar 21, 2024

Thank you for your contribution!

We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:

Submission Checklist 📝

  • I have updated existing examples or added new ones (if applicable).
  • My changes were added to the CHANGELOG.md in the proper section.

Extra:

Pull Request Details 📖

Description

This contains the necessary changes to get TWAI support for ESP32-C6.

Testing

I used two TWAI/CAN transceivers to connect one ESP32-C3 running the blocking twai example and one ESP32-C6 running the async example. Make sure to remove the ".into_open_drain_output()` when using transceivers.

@bjoernQ bjoernQ marked this pull request as ready for review March 21, 2024 14:04
Copy link
Member

@jessebraham jessebraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@jessebraham jessebraham enabled auto-merge March 21, 2024 14:44
@jessebraham jessebraham added this pull request to the merge queue Mar 21, 2024
Merged via the queue into esp-rs:main with commit 4e5020f Mar 21, 2024
17 checks passed
yanshay pushed a commit to yanshay/esp-hal that referenced this pull request Mar 25, 2024
* Enable TWAI for ESP32-C6

* CHANGELOG.md

* Make Clippy happy, again

* Make Clippy happy. For real this time

* Remove debug code
@bjoernQ bjoernQ deleted the esp32c6-twai branch November 26, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants