-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document msrv toolchain per chip hal #1058
Conversation
MabezDev
commented
Jan 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Was this +
intended?
Few things:
|
I agree having a version on the toolchain also for Xtensa would make sense - then everything is in one place Dropping the chapter on the MSRV is also probably good since it's almost duplicated then - we will just loose the hint on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I've made the documentation changes, however, I'm not sure what to do about the actual CI checks. For reference, the reason I'm adding this info is that any esp-hal version <0.14 will stop working after |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - we could mention the thing about versions < 14 and version 14+ and their requirements ... but on the other hand we probably should document the current requirement here
If it causes confusion we can still change it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For now I'll just merge this, and will do a full review of things again before releasing. If we decide to make any changes we can then, not the end of the world.
So, LGTM, thanks!