Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make linker errors more helpful #94

Merged
merged 2 commits into from
Feb 7, 2025

Conversation

bjoernQ
Copy link
Collaborator

@bjoernQ bjoernQ commented Feb 5, 2025

I stumbled upon this "by accident" but thought it might be a good idea - but maybe I'm just a little bit too excited about this so if we don't think it's useful it's fine.

It will look like this

image

While users can't run into it with a freshly generated project they might add and change things which might make them run into it

I guess there are more things that could be helpful - I just didn't want to waste too much time with something we don't think is useful

@@ -1,7 +1,52 @@
fn main() {
linker_be_nice();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good name 😁

Copy link
Member

@SergioGasquez SergioGasquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think its a good thing to have! In the future this could point to some documentation in the troubleshooting/faq of the book, with steps on how to fix it and why it happens.

@bjoernQ
Copy link
Collaborator Author

bjoernQ commented Feb 7, 2025

Another situation this can be quite helpful with (in future) is when using esp-wifi with a custom allocator but forgetting to provide the additional required functions

@jessebraham jessebraham added this pull request to the merge queue Feb 7, 2025
Merged via the queue into esp-rs:main with commit de38c80 Feb 7, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants