Rename async_main to main #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjoernQ
reviewed
Feb 5, 2025
src/main.rs
Outdated
| @@ -342,6 +342,13 @@ fn main() -> Result<(), Box<dyn Error>> { | |||
| } | |||
| } | |||
|
|
|||
| if selected.contains(&"embassy".to_string()) { | |||
There was a problem hiding this comment.
This will work fine but I would prefer some template command like //FILENAME src/main.rs (or similar) - just to make it easier in future to add more variants of the main source file
Or we could change the INCLUDEFILE command to accept something like //INCLUDEFILE !embassy src/main.rs (the filename should be optional)
There was a problem hiding this comment.
But I'm also fine with doing it like it's done here and have an issue to rethink the approach
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.