Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check rustc+cargo, espflash, probe-rs #88

Merged
merged 2 commits into from
Feb 4, 2025

Conversation

bjoernQ
Copy link
Collaborator

@bjoernQ bjoernQ commented Feb 4, 2025

After generation this will show s.th. like this

image

It's just to hint the user in case of any problems - they can still update / install tools after the project is generated.

Closes #63

@bjoernQ
Copy link
Collaborator Author

bjoernQ commented Feb 4, 2025

Not sure this needs a changelog entry?

src/check.rs Show resolved Hide resolved
@SergioGasquez
Copy link
Member

Not sure this needs a changelog entry?

Imho, its worth an entry, its a new feature that we added

@bjoernQ bjoernQ added the skip-changelog No changelog modification needed label Feb 4, 2025
Copy link
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MabezDev MabezDev added this pull request to the merge queue Feb 4, 2025
@bjoernQ bjoernQ force-pushed the check-tool-versions branch from c083559 to 8b6da82 Compare February 4, 2025 13:27
@bjoernQ bjoernQ removed the skip-changelog No changelog modification needed label Feb 4, 2025
@bjoernQ
Copy link
Collaborator Author

bjoernQ commented Feb 4, 2025

Not sure this needs a changelog entry?

Imho, its worth an entry, its a new feature that we added

Sorry, can't read ... added

@bjoernQ bjoernQ removed this pull request from the merge queue due to a manual request Feb 4, 2025
@bjoernQ bjoernQ enabled auto-merge February 4, 2025 13:27
@bjoernQ bjoernQ added this pull request to the merge queue Feb 4, 2025
Merged via the queue into esp-rs:main with commit bfd226c Feb 4, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error: Could not execute process espflash flash --monitor .. No such file or directory
3 participants