Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version check #87

Merged
merged 2 commits into from
Jan 31, 2025
Merged

Conversation

SergioGasquez
Copy link
Member

Added the update check like we do in espup and espflash, I've also added a --skip-update-check flag like we have in those as users requested it for the other packages.

Tests:

Updating version on the package in Cargo.toml to 0.2.1 and running

❯ cargo r -r -- --chip esp32s3 tests --headless
   Compiling esp-generate v0.2.1 (/Users/sergio/Documents/Espressif/forks/esp-generate)
    Finished `release` profile [optimized] target(s) in 3.98s
     Running `target/release/esp-generate --chip esp32s3 tests --headless`
[2025-01-31T07:39:10Z WARN ] 🚀 A new version of esp-generate is available: v0.2.2
[2025-01-31T07:39:10Z WARN ] Current directory is already in a git repository, skipping git initialization

If we add the flag:

❯ cargo r -r -- --chip esp32s3 tests --headless --skip-update-check
    Finished `release` profile [optimized] target(s) in 0.09s
     Running `target/release/esp-generate --chip esp32s3 tests --headless --skip-update-check`
[2025-01-31T07:39:44Z WARN ] Current directory is already in a git repository, skipping git initialization

@SergioGasquez SergioGasquez linked an issue Jan 31, 2025 that may be closed by this pull request
Copy link
Collaborator

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bjoernQ bjoernQ added this pull request to the merge queue Jan 31, 2025
Merged via the queue into esp-rs:main with commit 1d22422 Jan 31, 2025
10 checks passed
@SergioGasquez SergioGasquez deleted the feat/version-checker branch January 31, 2025 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New version checker
2 participants