Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Format dependencies #71

Merged
merged 1 commit into from
Jan 14, 2025
Merged

Format dependencies #71

merged 1 commit into from
Jan 14, 2025

Conversation

SergioGasquez
Copy link
Member

Removed some lines between dependencies and empty space before bleps

bjoernQ
bjoernQ approved these changes Jan 14, 2025
View reviewed changes
Copy link
Collaborator

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I wonder if there is a formatter we could run on Cargo.toml after generation

@SergioGasquez SergioGasquez added the skip-changelog No changelog modification needed label Jan 14, 2025
@SergioGasquez
Copy link
Member Author

I wonder if there is a formatter we could run on Cargo.toml after generation

Maybe we could use https://github.com/tamasfe/taplo, havent tried it before

@SergioGasquez SergioGasquez added this pull request to the merge queue Jan 14, 2025
@jessebraham
Copy link
Member

I wonder if there is a formatter we could run on Cargo.toml after generation

Maybe we could use https://github.com/tamasfe/taplo, havent tried it before

This is used as the formatter by the Even Better TOML extension IIUC, I often add taplo.toml to my personal projects. Works fine.

Merged via the queue into esp-rs:main with commit e6745c0 Jan 14, 2025
10 of 11 checks passed
@SergioGasquez SergioGasquez deleted the feat/format-deps branch January 14, 2025 12:46
@SergioGasquez
Copy link
Member Author

Sounds nice, I might give it a shot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjoernQ bjoernQ bjoernQ approved these changes

Assignees
No one assigned
Labels
skip-changelog No changelog modification needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SergioGasquez @jessebraham @bjoernQ