-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UX experiment #113
UX experiment #113
Conversation
definitely adds some complexity and might take a user some time to understand what we could do it change the foreground color of a highlighted but available option - i.e. this looks like the first option in disabled and it's the initial state when entering that sub-menu other than that I think the main source of confusion is having relations between different screens ( |
81695c2
to
432bec3
Compare
Thanks! Is it better or worse if probe-rs shows up in two places? For me, probably not much better. How about if everything is grouped into one screen 🤔 |
c4fdd43
to
5e01414
Compare
I think now with the submenu it's better Maybe we shouldn't offer defmt via esp-println - that might make things a bit easier? |
I struggled a bit with this to be honest 😅. I think I would organize it like:
Thoughts? (if that's even possible) |
It's certainly possible, just not with the current software. We can't have default-on options, because the We also don't hide items currently. We could hide empty categories (as in, without active options), but that means they are hidden until you find out which option opens the door, while currently you can move over one of the items and we print what is required for it to become active.
Ironically, that is the option that needs the most hand-holding. We can hide it behind an advanced template, along with probe-rs and the RTT-related options, I think. We could use the same template project, just a different template yaml. The downside is that we can't list the template options via I guess I can figure out hiding options, that way we can probably have more advanced stuff, as well as separate probe-rs/espflash settings. |
d89180a
to
962a738
Compare
I think with the separate sub-sections it's much better |
I think these colors look a bit better const SELECTED_ACTIVE_BACKGROUND: Color = tailwind::BLUE.c950;
const SELECTED_INACTIVE_BACKGROUND: Color = tailwind::GRAY.c700;
const SELECTED_ACTIVE_STYLE: Style = Style::new()
.add_modifier(Modifier::BOLD)
.fg(TEXT_COLOR)
.bg(SELECTED_ACTIVE_BACKGROUND); Makes it imho more obvious the first option is selectable |
Definitely better, but not exactly the point of this PR :) I'll submit the ability to set these colors and the styling itself separately. |
it's also about UX - but sure another PR is fine |
a028a1a
to
09dcf96
Compare
This is now rebased on top of #119. One bug I see is that enabling |
2142454
to
f0cbde4
Compare
I've changed probe-rs to display a different help text for devices without usb-jtag (and c3, which I still don't know definitely whether it is borked or not). This needs some logic change, but I think it's an interesting possibility to provide chip-specific information. |
f0cbde4
to
e15b629
Compare
e15b629
to
93223f4
Compare
No description provided.