Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test from yaml #106

Merged
merged 5 commits into from
Feb 11, 2025
Merged

Test from yaml #106

merged 5 commits into from
Feb 11, 2025

Conversation

bugadani
Copy link
Contributor

I meant to do this as part of #103 but that was merged before I started :) For current options, the PR returns the same lists for both all_configurations and !all_configurations as before, but we no longer have to maintain that list.

@bugadani bugadani marked this pull request as ready for review February 11, 2025 09:35
@bjoernQ
Copy link
Collaborator

bjoernQ commented Feb 11, 2025

Locally running cargo xtask check esp32c3 fails in the end with

[2025-02-11T10:24:43Z INFO  xtask] CHECK: esp32c3
[2025-02-11T10:24:43Z INFO  xtask] WITH OPTIONS: []
[2025-02-11T10:24:43Z INFO  xtask] PROJECT PATH: "C:\\Users\\bq\\AppData\\Local\\Temp\\.tmpBeKkZK"
...
error: failed to run custom build command for `ring v0.17.8`

Caused by:
  process didn't exit successfully: `\\?\D:\projects\upstream\esp-generate\target\release\build\ring-38d479423266d8b2\build-script-build` (exit code: 1)
...
warning: build failed, waiting for other jobs to finish...
Error: Der Verzeichnisname ist ungültig. (os error 267)
error: process didn't exit successfully: `xtask\target\debug\xtask.exe check esp32c3` (exit code: 1)
err process exited unsuccessfully: exit code: 1

I think ring comes from Rustls comes from update-informer but why?

@bugadani
Copy link
Contributor Author

I don't know, I've never been able to run the checks locally.

Copy link
Collaborator

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of Windows in your other PR

@bjoernQ bjoernQ added this pull request to the merge queue Feb 11, 2025
Merged via the queue into main with commit a92c597 Feb 11, 2025
10 checks passed
@bugadani bugadani deleted the test-from-yaml branch February 11, 2025 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants