This repository has been archived by the owner on Apr 16, 2024. It is now read-only.
Re-write the allocator to use the linked-list-allocator crate
#2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjoernQ
reviewed
May 31, 2022
|
Looks good - really curious to see how this works with esp-wifi |
bjoernQ
approved these changes
May 31, 2022
MabezDev
reviewed
May 31, 2022
MabezDev
approved these changes
May 31, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the linked-list-allocator crate instead of the previous hand-crafted allocator.
I have created a repository containing two projects testing this functionality. Note that for whatever reason on Xtensa using
panic-haltwith this seems to cause linker errors, however defining our own panic handler works fine. For RISC-V it works fine withpanic-halt. Not sure what's going on there. Anyways, repo:https://github.com/jessebraham/alloc-test
I have also already pinned this dependency in
esp-wifito the currentHEAD, so merging this will not cause issues with that project.