Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move to the smaller, cargo-team maintained home crate #73

Merged
merged 1 commit into from
May 8, 2023
Merged

Move to the smaller, cargo-team maintained home crate #73

merged 1 commit into from
May 8, 2023

Conversation

utkarshgupta137
Copy link
Contributor

No description provided.

@ivmarkov
Copy link
Collaborator

ivmarkov commented May 7, 2023

Can you elaborate a bit what problem is solved by using this dependency instead of dirs?

@utkarshgupta137
Copy link
Contributor Author

The dirs crate is a relatively big dependency that has been abandoned in the past for a simple function that is now maintained by the cargo team. It also now inherits an MPL-licensed dependency, which is not allowed in certain environments.

@ivmarkov
Copy link
Collaborator

ivmarkov commented May 8, 2023

Fair enough. Thanks and merged!

@ivmarkov ivmarkov merged commit bcfa152 into esp-rs:master May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@utkarshgupta137 @ivmarkov