Fix issue that bitrate is ignored when burst is set (with Nanosleep) #1821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR, we'll take a look! Do you think this problem is specific to Windows (only asking because that was mentioned in the original bug report in #1820)? We'll get this fixed in the next release either way. |
|
The problem general for all systems and is not specific to Windows. |
bmah888
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version of iperf3 (or development branch, such as
masteror3.1-STABLE) to which this pull request applies:master
Issues fixed (if any): Iperf3.18 - packet count for burst mode seems broken when sending UDP traffic (on Windows) #1820
Brief description of code changes (suitable for use as a commit message):
Fix a bug that was introduced in PR #1773 (my PR ...) that bit bitrate is ignored when burst is set (and nanosleep is supported). The bug was that once there was a green light for sending, throttling was never evaluated.