Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Remove feature flag for NestedFolders #304

Closed
safaci2000 opened this issue Sep 15, 2024 · 0 comments
Closed

[BUG] Remove feature flag for NestedFolders #304

safaci2000 opened this issue Sep 15, 2024 · 0 comments
Assignees
@safaci2000
Labels
bug Something isn't working
Milestone
0.7.2

Comments

@safaci2000
Copy link
Contributor

Describe the bug

The warning being printed if nested flag is not set is not needed for version 11+. That check should be removed in future versions.

To Reproduce
set dashboard_settings.nested_folders = true

and list the dashboards without setting the: GF_FEATURE_TOGGLES_ENABLE=nestedFolders

Expected behavior
No warning should be printed, if version check passes.

Desktop (please complete the following information):

  • GDG Version: v0.7.1
  • Grafana Version: 11+
@safaci2000 safaci2000 added the bug Something isn't working label Sep 15, 2024
@safaci2000 safaci2000 added this to the 0.7.2 milestone Sep 15, 2024
@safaci2000 safaci2000 self-assigned this Sep 15, 2024
safaci2000 added a commit that referenced this issue Dec 18, 2024
@safaci2000
Removing Nested requirements, Fixes #304
23ec54d 
ChangeLog:
  - Fixing nested validation logic.
  - Adding contact points documentation.
  - Adding documentation for dashboard config settings
safaci2000 added a commit that referenced this issue Dec 18, 2024
@safaci2000
Removing Nested requirements, Fixes #304
e3c60fc 
ChangeLog:
  - Fixing nested validation logic.
  - Adding contact points documentation.
  - Adding documentation for dashboard config settings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@safaci2000 safaci2000

Labels
bug Something isn't working
Projects
None yet
Milestone
0.7.2
Development

No branches or pull requests
1 participant
@safaci2000