BLD: Add metadata to ESMPy pyproject.toml #315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
billsacks
approved these changes
Jan 16, 2025
There was a problem hiding this comment.
Thank you very much for submitting these changes, @DWesl ! I'm sorry it took us a long time to get to this, but I just reviewed this and this all looks good to me, so I'll merge it shortly.
And yes, I'll also uncomment the specification of readme.
Thanks again for the contribution!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Authors taken from setup.py before #58.
One URL taken from setup.py, others taken from that page.
Classifiers added by me.
Closes #140.
Should I also uncomment the
readmespecification on line 8? What's there should work fine