Attempt surround desync fix #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the settings page toggles for the chord and vim mode display. Fixed the custom keybinds not resetting when completing. The "vim-command-done" event seems to be not registering them. Maybe a problem with initialization of the keys? Changed the plugin to be desktop only. It's unlikely that someone could use this on mobile, and cmEditor is deprecated and will only work on desktop for now.
Closed
esm7
approved these changes
Sep 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempting to fix the bug reported in #39.
I'm thinking that CM could be reporting multiple selections when only one exists (bug).
So my attempt to fix it just gets the selection that CM says matches the current cursor.
This could actually break functionality if users wish to surround multiple selections at the same time using
alt-click, but it's probably more likely that users are only using single selections.Also, I was unable to recreate the problem, so there's a chance that this change does nothing good.