Breaking: typescript-estree v5 #538
Conversation
kaicataldo
force-pushed
the
typescript-estree-v5
branch
3 times, most recently
from
82449a2 to
476e082
Compare
kaicataldo
changed the title
kaicataldo
force-pushed
the
typescript-estree-v5
branch
2 times, most recently
from
df75a41 to
e58116e
Compare
kaicataldo
force-pushed
the
typescript-estree-v5
branch
from
e58116e to
4fbef06
Compare
| function createSnapshotTestBlock(code, config) { | ||
| function createSnapshotTestBlock(code, config = {}) { | ||
| const defaultConfig = { | ||
| loc: true, |
There was a problem hiding this comment.
Default options passed to the parser by ESLint. I added errorOnUnknownASTType since it was added in a lot of the tests.
|
FYI, I renamed the label in this repository from "DO NOT MERGE" to "do not merge" so that the bot will add a pending status check for it. Hopefully the pending status check is a stronger signal to not merge something than the capitalization. |
| range: true, | ||
| raw: true, | ||
| tokens: true, | ||
| comment: true, |
There was a problem hiding this comment.
Not all the tests had comment: true, which is what is causing a lot of diffs in the snapshots. I personally think it's fine to have this always set.
|
|
||
| The following additional configuration options are available by specifying them in [`parserOptions`](https://eslint.org/docs/user-guide/configuring#specifying-parser-options) in your ESLint configuration file. | ||
|
|
||
| **`jsx`** - default `false`. Enable parsing JSX when `true`. More details can be found [here](https://www.typescriptlang.org/docs/handbook/jsx.html). |
There was a problem hiding this comment.
There are technically other options (range, loc, comment, etc.), but these aren't particularly useful for the end user, since ESLint supplies them. I think we should document the API (parse(), parseForESLint(), etc.) and document those options there.
|
FYI: In another issue, I promised I would cut a major release (to change ESLint from a dependency to a peerDependency/devDependency) at some point. I think it would be great to include both changes in the next major release. I'm okay with handling the release, but if you would prefer to do it, let me know if you have questions. So in summary: Please merge this whenever you feel ready, but please consult me or at least check the package.json file before cutting a release. Thanks! |
|
@platinumazure I'm going to merge this now. Happy to take on those other changes and cut a release! |
|
PR here |
Following up on JamesHenry/typescript-estree#22, this updates to the latest version of typescript-estree.
Looks like it might also fix #503.
I think we should remove support for
ecmaFeaturesin the options and add individual feature flags if we need them in the future (which seems unlikely). Thoughts?