Only warn about an unsupported TypeScript version once

[j-f1]

It gets annoying when you’re trying to lint a project with lots of files. Fixes #348.

[eslintbot]

Thanks for the pull request, @j-f1! I took a look to make sure it's ready for merging and found some changes are needed:

• The commit summary needs to begin with a tag (such as Fix: or Update:). Please check out our guide for how to properly format your commit summary and update it on this pull request.

• Pull requests with code require an issue to be mentioned at the end of the commit summary, such as (fixes #1234). Please update the commit summary with an issue (file a new issue if one doesn't already exist).

Can you please update the pull request to address these?

(More information can be found in our pull request guide.)

[soda0289]

I think we can move the warning text outside the parse() that should eliminate the use of a global variable

[eslintbot]

LGTM

[eslintbot]

LGTM

[j-f1]

@soda0289 Done!

[eslintbot]

LGTM

[soda0289]

@j-f1
Thanks for making the change but on a second look I noticed we need to have access to the extra.log() and dont think this should be outside parse(). That was added since we did not want to write logs when other projects that use this parser. We still need to have the ability for users of the library to overwrite the logger.

I think we will have to use the global variable. We should move the warning text to its own function and contain the logic of checking if it has been called to there. Sorry for the confusion and thanks for the PR.

[eslintbot]

LGTM

[eslintbot]

LGTM

[eslintbot]

LGTM

[JamesHenry]

This is a bit odd 😄 Why not put the // eslint-disable-line valid-jsdoc on the line of the function you are disabling? Alternatively you could use Function.prototype as the value of the noop

[j-f1]

If I don’t add the JSDoc comment, it errors at line 98 instead. I’ll switch to Function.prototype.

[eslintbot]

LGTM

[JamesHenry]

Thanks a lot for this @j-f1!