Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update README #383

Merged
merged 1 commit into from
Jul 19, 2024
Merged

docs: update README #383

merged 1 commit into from
Jul 19, 2024

Conversation

Romick2005
Copy link
Contributor

We need to add recommended value for no-multiple-resolved rule

What is the purpose of this pull request?

  • [ x] Documentation update
  • Bug fix
  • New rule
  • Changes an existing rule
  • Add autofixing to a rule
  • Other, please explain:

What changes did you make? (Give an overview)

@MichaelDeBoey MichaelDeBoey changed the title Update README.md docs: update README Oct 13, 2022
@brettz9
Copy link
Member

brettz9 commented Jul 6, 2024

Is this a proposal to make the rule recommended? Because the rule is not currently a recommended rule and should therefore not be documented as such unless a change is made.

@Romick2005
Copy link
Contributor Author

If it is not documented and is not explicitly stated as deprecated, then maybe we should just remove it?

@brettz9
Copy link
Member

brettz9 commented Jul 6, 2024

It is documented elsewhere on the page, but maybe it doesn't hurt to list all of the rules there in some fashion. But note that that list is not a recommended list--it is just indicating possible rules to pick from. The list of recommended rules is indicated later on the page.

We need to add recommended value for no-multiple-resolved rule
Copy link

codecov bot commented Jul 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (bbcfcbf) to head (4395545).
Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #383   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           25        24    -1     
  Lines          649       660   +11     
  Branches       250       246    -4     
=========================================
+ Hits           649       660   +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@brettz9 brettz9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brettz9 brettz9 merged commit d8d0fbe into eslint-community:main Jul 19, 2024
17 checks passed
Copy link
Contributor

🎉 This PR is included in version 6.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants