perf: improve prefer-node-protocol
's performance
#406
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #404.
The main change is avoiding an expensive iteration with
ReferenceTracker.iterateGlobalReferences
by operating directly on ESLint'sCallExpression
s. I've used a similar approach for ESM imports/exports too rather than sticking with"Program:exit"
.Benchmarks and smoke tests were done in the Svelte repository. Both reporting and
--fix
ing works as expected.master
branch:prefer-node-protocol-performance
branch: