Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[API DOCS] Ambilight: /cached, /lounge & isExpert #89

Closed
buschtoens opened this issue Jan 7, 2021 · 3 comments
Closed

[API DOCS] Ambilight: /cached, /lounge & isExpert #89

buschtoens opened this issue Jan 7, 2021 · 3 comments

Comments

@buschtoens
Copy link

Semi-related to #70.

Thanks a lot for this excellent project and the reverse-engineered docs. I wouldn't have looked deeper into all of this, if it wasn't for your fundamental work!

I noticed that the docs around /cached & /lounge, as well as the isExpert option on /currentconfiguration are very thin. I got nerd-sniped and dicked around with the Philips TV Remote app. No fancy MITM (yet); just triggering something in the app and then querying the different GET endpoints to see what changed.

I have a pretty clear picture of how to use these configs now and would like to contribute them back. As the wiki is only writable for collaborators, what would be your preferred way for me to upstream the changes?

  • I summarize them here.
  • I fork the wiki .git and push it to a repo.
  • You make me a collaborator.
  • You lift the wiki write access restriction.
  • The wiki gets obsoleted and the content is moved to this repo or a separate repo. Docs could be auto-deployed to GitHub Pages, e.g. using Jekyll.
@eslavnov
Copy link
Owner

eslavnov commented Jan 8, 2021

Hi @buschtoens!

Thank you for your input! I've been thinking about moving the docs to the repo and this is a nice extra motivation for me to do this! I'll handle it over the weekend and then you can create a PR with your updates (which would be extremely welcomed!).

@buschtoens
Copy link
Author

Fantastic! Let me know, once you're ready and I'll get to it. 😊

eslavnov added a commit that referenced this issue Jan 17, 2021
eslavnov added a commit that referenced this issue Jan 17, 2021
@eslavnov
Copy link
Owner

Hi @buschtoens, my apologies for the delay, but I've finally moved the docs into the repo so feel free to send a PR with your contributions! Thanks in advance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants