Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully this fixes more than breaks, feel free take lines of code from this
branch if the PR is too much, no problem about attribution if this is the case
Looks like a rewrite, but mostly due to variable re-naming to get
a better idea of how things align with the manual
Added comments for the instruction display and byte sequence
Added ESPR and SPR registers to pspec and better handled in slaspec
which cleaned up the 8-bit addressing code
Added DWARF mapping just cause I had that document out reading up on (E)SPR
Still need to add to the ldef if it looks good and you want to include it
Minor bug fixes in display section (shouldnt affect analysis, just readability)
Minor bug fixes in a few table constructors ('mem' change should be noticeable)
Cleaned up access to IP, previously the high byte could get cut off
Cleaned up SP access, previously used 'Stack' variable instead of SP
This might need revisiting (how are all the different stacks setup?)
ATTN I did probably break signed a lot since the 2's complement description
vs the supplied data didn't make sense to me (how #dataN work)
but since you have flag tracking so well, it should/might pick up that
detail in the decompiler