Replace redis cluster with nats #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
redis cluster and sentenal don't do lists / blpop very well and run the risk of missing messages and duplicates
only consider it to be json, if it is an object. strings don't need to be encoded integration tests start
We want to unsubscribe before dispatching messages so the node that is shutting down doesn't get it's own messages
make sure the node going down unsubscribes first so it doesn't get it's own messages
esatterwhite
added a commit
that referenced
this pull request
Mar 17, 2020
esatterwhite
added a commit
that referenced
this pull request
Mar 18, 2020
* initial commit * add stream and batch support * test: adding some test * backend: make sure to slugify location for scylla table
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The timer rebalance function was implemented with redis using
rpushandblpop. with redis cluster, list keys are not shared between servers, so there is pretty high likelyhood that none of the other servers get any updates during a rebalanace.with sentenal, there is a chance of duplicate messages.
Replacing redis with Nats using queue groups which guarantees at most once delivery of messages, and spreads work between nodes.