validator: make sure the requested transport is enabled

lib/server/api/validators/timer.js

@@ -1,5 +1,7 @@
 'use strict'
 const type_exp = /^\[object (.*)\]$/
+const transports = require('../../../transports')
+
 function typeOf(obj) {
   if (obj === null) return 'Null';
   if (obj === undefined) return 'Undefined';
@@ -26,12 +28,18 @@ module.exports = function(data = {}, cb) {
     err.statusCode = 400;
     return setImmediate(cb, err);
   }
+
   if (typeOf(data.callback.transport) !== 'String') {
     const err = new TypeError('callback.transport is required and must be a string');
     err.statusCode = 400;
     return setImmediate(cb, err);
   }
 
+  if (typeOf(transports[data.callback.transport]) !== 'Function') {
+    const err = new Error(`unknown transport ${data.callback.transport}`)
+    err.statusCode = 400
+    return setImmediate(cb, err)
+  }
   if (typeOf(data.callback.uri) !== 'String') {
     const err = new TypeError('callback.uri is required and must be a string');
     err.statusCode = 400;

lib/transports/index.js

@@ -9,27 +9,15 @@
  */
 
 const callback = require('./callback')
+const ENV = process.env.NODE_ENV
  /**
   * DESCRIPTION
   * @memberof module:skyring/lib/transports
   * @property {Object} http The HTTP transport
   **/
 exports.http = require('./http');
 
-Object.defineProperty(exports, 'callback',{
-  enumerable: false
-, configurable: false
-, get: function(){
-    switch(process.env.NODE_ENV){
-      case 'production':
-      case 'prod':
-        const err = new Error('callback transport is for testing only')
-        err.name = 'TransportError';
-        err.code = 'ENOTRANSPORT';
-        throw err;
+if(!ENV || ENV === 'development' || ENV === 'test') {
+  exports.callback = callback
+}
 
-      default:
-        return callback;
-    }
-  }
-});