Merge pull request #83 from uber/non-dynamic-logs

remove dynamic log messages
esatterwhite · May 27, 2015 · ed83275 · ed83275
2 parents e88d3a8 + ae62e5c
commit ed83275
Showing 1 changed file with 7 additions and 2 deletions.
diff --git a/lib/swim/ping-req-sender.js b/lib/swim/ping-req-sender.js
@@ -88,7 +88,10 @@ PingReqSender.prototype.send = function send() {
 
 PingReqSender.prototype.onPingReq = function (err, res1, res2) {
     if (err) {
-        this.ring.logger.warn('bad response to ping-req from ' + this.member.address + ' err=' + err.message);
+        this.ring.logger.warn('bad response to ping-req', {
+            address: this.member.address,
+            err: err
+        });
         this.callback(PingReqPingError({
             errMessage: err.message
         }));
@@ -98,7 +101,9 @@ PingReqSender.prototype.onPingReq = function (err, res1, res2) {
     var res2Str = res2.toString();
     var bodyObj = safeParse(res2Str);
     if (! bodyObj || !bodyObj.changes || bodyObj.pingStatus === 'undefined') {
-        this.ring.logger.warn('bad response body in ping-req from ' + this.member.address);
+        this.ring.logger.warn('bad response body in ping-req', {
+            address: this.member.address
+        });
         this.callback(BadPingReqRespBodyError({
             selected: this.member.address,
             target: this.target.address,