Skip to content

Commit

Permalink
Favor string concatenation over join()
Browse files Browse the repository at this point in the history
  • Loading branch information
jwolski committed Jun 23, 2015
1 parent a7ad86f commit ea0c271
Showing 1 changed file with 16 additions and 4 deletions.
20 changes: 16 additions & 4 deletions lib/membership.js
Original file line number Diff line number Diff line change
Expand Up @@ -64,15 +64,27 @@ Membership.prototype.findMemberByAddress = function findMemberByAddress(address)
};

Membership.prototype.generateChecksumString = function generateChecksumString() {
var checksumStrings = [];
var sortedMembers = this.members.sort(function sort(a, b) {
if (a.address < b.address) {
return -1;
} else if (a.address > b.address) {
return 1;
} else {
return 0;
}
});

var checksumString = '';

for (var i = 0; i < this.members.length; ++i) {
for (var i = 0; i < sortedMembers.length; ++i) {
var member = this.members[i];

checksumStrings.push(member.address + member.status + member.incarnationNumber);
checksumString += member.address +
member.status +
member.incarnationNumber + ';';
}

return checksumStrings.sort().join(';');
return checksumString.substring(0, checksumString.length - 1);
};

Membership.prototype.getIncarnationNumber = function getIncarnationNumber() {
Expand Down

0 comments on commit ea0c271

Please sign in to comment.