get 100% code coverage with tests

esatterwhite · Aug 17, 2015 · c93f2b6 · c93f2b6
1 parent 57ccec8
commit c93f2b6
Show file tree

Hide file tree

Showing 2 changed files with 66 additions and 0 deletions.
diff --git a/test/integration/tchannel-proxy-test.js b/test/integration/tchannel-proxy-test.js
@@ -83,3 +83,67 @@ TChannelProxyCluster.test('RingpopHandler for two', {
         assert.end();
     }
 });
+
+TChannelProxyCluster.test('RingpopHandler for two', {
+    size: 3
+}, function t(cluster, assert) {
+    cluster.client.request({
+        serviceName: cluster.serviceName,
+        headers: {
+            sk: cluster.keys.two
+        },
+        host: cluster.hosts.one
+    }).send('ping', '', '', onResponse);
+
+    function onResponse(err, resp, arg2, arg3) {
+        assert.ifError(err);
+
+        assert.ok(resp.ok);
+        assert.equal(arg3.toString(), 'ping from two');
+
+        assert.end();
+    }
+});
+
+TChannelProxyCluster.test('RingpopHandler blacklist', {
+    size: 3,
+    blacklist: {
+        'ping': true
+    }
+}, function t(cluster, assert) {
+    cluster.client.request({
+        serviceName: cluster.serviceName,
+        headers: {
+            sk: cluster.keys.two
+        },
+        host: cluster.hosts.one
+    }).send('ping', '', '', onResponse);
+
+    function onResponse(err, resp, arg2, arg3) {
+        assert.ifError(err);
+
+        assert.ok(resp.ok);
+        assert.equal(arg3.toString(), 'ping from one');
+
+        assert.end();
+    }
+});
+
+TChannelProxyCluster.test('RingpopHandler bad request', {
+    size: 3
+}, function t(cluster, assert) {
+    cluster.client.request({
+        serviceName: cluster.serviceName,
+        host: cluster.hosts.one
+    }).send('ping', '', '', onResponse);
+
+    function onResponse(err, resp, arg2, arg3) {
+        assert.ok(err);
+
+        assert.equal(err.codeName, 'BadRequest');
+        assert.equal(err.message,
+            '[ringpop] Request does not have sk header set');
+
+        assert.end();
+    }
+});
diff --git a/test/lib/tchannel-proxy-cluster.js b/test/lib/tchannel-proxy-cluster.js
@@ -39,6 +39,7 @@ function TChannelProxyCluster(options) {
     var self = this;
 
     self.size = options.size;
+    self.blacklist = options.blacklist;
     self.serviceName = options.serviceName || 'app';
 
     self.keys = null;
@@ -108,6 +109,7 @@ function setupHandler(name, ringpop) {
         realHandler: realHandler,
         channel: channel,
         ringpop: ringpop,
+        blacklist: self.blacklist,
         logger: ringpop.logger
     });