Return responses as an array instead of an object

esatterwhite · Feb 12, 2015 · a27670e · a27670e
1 parent fac750f
commit a27670e
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 7 deletions.
diff --git a/index.js b/index.js
@@ -853,7 +853,7 @@ RingPop.prototype.handleOrProxyAll =
         var keysByDest = _.groupBy(keys, this.lookup, this);
         var dests = Object.keys(keysByDest);
         var pending = dests.length;
-        var responses = {};
+        var responses = [];
 
         dests.forEach(function(dest) {
             var res = hammock.Response();
@@ -883,11 +883,11 @@ RingPop.prototype.handleOrProxyAll =
         });
 
         function onResponse(err, response, dest) {
-            responses[dest] = {
+            responses.push({
                 res: response,
                 dest: dest,
                 keys: keysByDest[dest]
-            };
+            });
             if ((--pending === 0 || err) && cb) {
                 cb(err, responses);
                 cb = null;

diff --git a/test/integration/handle_or_proxy_test.js b/test/integration/handle_or_proxy_test.js
@@ -77,10 +77,8 @@ test('handleOrProxyAll() proxies and calls local handler', function t(assert) {
     function onResponses(err, responses) {
         assert.ifError(err);
 
-        var hosts = Object.keys(responses);
-        assert.equal(hosts.length, 3);
-        hosts.forEach(function(host) {
-            var data = responses[host];
+        assert.equal(responses.length, 3);
+        responses.forEach(function(data) {
             assert.equal(data.res.statusCode, 200);
             tryIt(function parse() {
                 var body = JSON.parse(data.res.body);