Move location of request proxy stats so we get them with or without r…

…etries
esatterwhite · Jun 1, 2015 · 6fff7de · 6fff7de
1 parent 9b39be8
commit 6fff7de
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/lib/request-proxy/index.js b/lib/request-proxy/index.js
@@ -124,13 +124,16 @@ proto.proxyReq = function proxyReq(opts) {
             self.removeSend(send);
 
             if (err) {
+                self.ringpop.stat('increment', 'requestProxy.send.error');
                 self.ringpop.logger.warn('requestProxy got error from tchannel', {
                     err: err,
                     url: req.url
                 });
                 return sendError(res, err);
             }
 
+            self.ringpop.stat('increment', 'requestProxy.send.success');
+
             var responseHead = safeParse(res1) || {};
 
             if (responseHead.headers) {

diff --git a/lib/request-proxy/send.js b/lib/request-proxy/send.js
@@ -235,12 +235,10 @@ RequestProxySend.prototype.send = function send(channelOpts, callback) {
 
     function onSend(err, res1, res2) {
         if (!err) {
-            self.ringpop.stat('increment', 'requestProxy.send.success');
             self.handleSuccess(res1, res2, callback);
             return;
         }
 
-        self.ringpop.stat('increment', 'requestProxy.send.error');
         self.errors.push(err);
 
         if (self.numRetries >= self.maxRetries) {