Skip to content

Commit

Permalink
A couple quick cleanups for LoggerFactory
Browse files Browse the repository at this point in the history
  • Loading branch information
jwolski committed Nov 25, 2015
1 parent 76cb4d8 commit 61cd510
Showing 1 changed file with 20 additions and 14 deletions.
34 changes: 20 additions & 14 deletions lib/logging/logger_factory.js
Original file line number Diff line number Diff line change
Expand Up @@ -21,24 +21,29 @@

var ModuleLogger = require('./module_logger.js');

// TODO This mapping should eventually go away. It seems that log
// level names by convention (logger name + "LogLevel") is the way
// to go.
var loggerNamesToLevels = {
damping: 'dampingLogLevel',
dissemination: 'disseminationLogLevel',
gossip: 'gossipLogLevel',
join: 'joinLogLevel',
membership: 'membershipLogLevel',
suspicion: 'suspicionLogLevel',
};

function LoggerFactory(opts) {
this.ringpop = opts.ringpop;
this.defaultLogger = new ModuleLogger(this.ringpop, 'defaultLogLevel');
this.loggers = {}; // indexed by name
// TODO This mapping should eventually go away. It seems that log
// level names by convention (logger name + "LogLevel") is the way
// to go.
this.loggerNamesToLevels = {
damping: 'dampingLogLevel',
dissemination: 'disseminationLogLevel',
gossip: 'gossipLogLevel',
join: 'joinLogLevel',
membership: 'membershipLogLevel',
suspicion: 'suspicionLogLevel',
};
this.defaultLogger = new ModuleLogger(this.ringpop, 'defaultLogLevel');
}

LoggerFactory.prototype.getLogger = function getLogger(name) {
if (!name) {
return this.defaultLogger;
}

if (this.loggers[name]) {
return this.loggers[name];
}
Expand All @@ -47,9 +52,10 @@ LoggerFactory.prototype.getLogger = function getLogger(name) {
};

LoggerFactory.prototype._createLogger = function _createLogger(name) {
var level = this.loggerNamesToLevels[name] || 'defaultLogLevel';
var level = loggerNamesToLevels[name];
if (!level) return this.defaultLogger;
this.loggers[name] = new ModuleLogger(this.ringpop, level);
return this.loggers[name];
}
};

module.exports = LoggerFactory;

0 comments on commit 61cd510

Please sign in to comment.