Skip to content

Commit

Permalink
Update tchan to 3.6.13 and fix two tests that broke because of it. On…
Browse files Browse the repository at this point in the history
…e test added '001' to the hostport to make it unreachable, tchannel doesn't allow huge port no.s anymore. The other test failed because: 'AssertionError: TChannel must listen on top channel'. Listening to the rootChannel fixed the test.
  • Loading branch information
Wieger Steggerda committed Feb 10, 2016
1 parent 4e3cdb1 commit 4997cc8
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@
"pre-commit": "^0.0.9",
"tape": "^3.0.3",
"tape-cluster": "2.1.0",
"tchannel": "^2.10.1",
"tchannel": "^3.6.13",
"tcurl": "^4.11.1",
"time-mock": "^0.1.2",
"tryit": "^1.0.1",
Expand Down
2 changes: 1 addition & 1 deletion test/integration/gossip_test.js
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,7 @@ testRingpopCluster({
// unreachable and therefore, the results of ping-req inconclusive.
ringpop.membership.members.forEach(function eachMember(member) {
if (member.address !== unreachableMember.address) {
member.address += '001';
member.address = member.address.split(':')[0]+":9999"
}
});

Expand Down
2 changes: 1 addition & 1 deletion test/lib/tchannel-proxy-cluster.js
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ TChannelProxyCluster.prototype.bootstrap = function bootstrap(cb) {
self.setupHandler('one', self.cluster.one);
self.setupHandler('two', self.cluster.two);
self.setupHandler('three', self.cluster.three);
self.client.listen(0, '127.0.0.1', onListen);
self.clientRootChannel.listen(0, '127.0.0.1', onListen);
}

function onListen() {
Expand Down

0 comments on commit 4997cc8

Please sign in to comment.