Add a comment clarifying removeListener

esatterwhite · Oct 6, 2015 · 4910763 · 4910763
1 parent bf1dbce
commit 4910763
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/lib/membership/index.js b/lib/membership/index.js
@@ -286,7 +286,11 @@ Membership.prototype.update = function update(changes, isLocal) {
             continue;
         }
 
-        // One-time subscription for batching applied updates
+        // One-time subscription for batching applied updates. Make
+        // sure to unsubscribe immediately after evaluating the update.
+        // Events are expected to be emitted synchronously and are not
+        // guaranteed if the update is determined to be invalid or
+        // redundant.
         member.once('updated', onMemberUpdated);
         member.evaluateUpdate(change);
         member.removeListener('updated', onMemberUpdated);