JSHint the lib/ directory

esatterwhite · Mar 7, 2015 · 297ff77 · 297ff77
1 parent 07ea0f7
commit 297ff77
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 5 deletions.
diff --git a/lib/members.js b/lib/members.js
@@ -64,7 +64,10 @@ Dissemination.prototype.adjustMaxPiggybackCount = function adjustMaxPiggybackCou
 Dissemination.prototype.getChanges = function getChanges(checksum, source) {
     var changesToDisseminate = [];
 
-    for (var address in this.changes) {
+    var changedNodes = Object.keys(this.changes);
+
+    for (var i = 0; i < changedNodes.length; i++) {
+        var address = changedNodes[i];
         var change = this.changes[address];
 
         // TODO We're bumping the piggyback count even though
@@ -321,7 +324,7 @@ Membership.prototype.getRandomPingableMembers = function(n, excluding) {
         .value();
 };
 
-Membership.prototype.getState = function(incomingChecksum) {
+Membership.prototype.getState = function() {
     return this.members.map(function(member) {
         return {
             address: member.address,

diff --git a/lib/rbtree.js b/lib/rbtree.js
@@ -40,7 +40,7 @@ RingNode.prototype.setChild = function(dir, val) {
     }
 };
 
-RBTree = function RBTree() {
+var RBTree = function RBTree() {
     this.root = null;
     this.size = 0;
 };
@@ -188,6 +188,7 @@ RBTree.prototype.remove = function(val) {
             } else if (!isRed(node.getChild(!dir))) {
                 var sibling = p.getChild(!lastDir);
                 if (sibling !== null) {
+                    /* jshint -W073 */
                     if (!isRed(sibling.getChild(!lastDir)) && !isRed(sibling.getChild(lastDir))) {
                         // color flip
                         p.red = false;

diff --git a/lib/swim.js b/lib/swim.js
@@ -21,7 +21,6 @@ var clearTimeout = require('timers').clearTimeout;
 var globalSetTimeout = require('timers').setTimeout;
 var metrics = require('metrics');
 var safeParse = require('./util').safeParse;
-var TypedError = require('error/typed');
 
 function PingReqSender(ring, member, target, callback) {
     this.ring = ring;

diff --git a/package.json b/package.json
@@ -16,7 +16,7 @@
     "add-licence": "uber-licence",
     "check-licence": "uber-licence --dry",
     "cover": "istanbul cover --print detail --report html test/index.js",
-    "jshint": "jshint --verbose *.js",
+    "jshint": "jshint --verbose *.js lib/*.js",
     "travis": "npm run cover -s && istanbul report lcov && ((cat coverage/lcov.info | coveralls) || exit 0)",
     "view-cover": "opn coverage/index.html"
   },