Address Ben's PR feedback; rename handler functions for easier debugg…

…ability
esatterwhite · Aug 26, 2015 · 0ccffcc · 0ccffcc
1 parent a20ae4f
commit 0ccffcc
Show file tree

Hide file tree

Showing 9 changed files with 18 additions and 18 deletions.
diff --git a/server/admin/debug-clear.js b/server/admin/debug-clear.js
@@ -19,8 +19,8 @@
 // THE SOFTWARE.
 'use strict';
 
-module.exports = function createHandler(ringpop) {
-    return function handle(arg1, arg2, hostInfo, callback) {
+module.exports = function createDebugClearHandler(ringpop) {
+    return function handleDebugClear(arg1, arg2, hostInfo, callback) {
         ringpop.clearDebugFlags();
         callback(null, null, 'ok');
     };

diff --git a/server/admin/debug-set.js b/server/admin/debug-set.js
@@ -21,8 +21,8 @@
 
 var safeParse = require('../../lib/util.js').safeParse;
 
-module.exports = function createHandler(ringpop) {
-    return function handle(arg1, arg2, hostInfo, callback) {
+module.exports = function createDebugSetHandler(ringpop) {
+    return function handleDebugSet(arg1, arg2, hostInfo, callback) {
         var body = safeParse(arg2.toString());
         if (body && body.debugFlag) {
             ringpop.setDebugFlag(body.debugFlag);

diff --git a/server/admin/gossip.js b/server/admin/gossip.js
@@ -19,8 +19,8 @@
 // THE SOFTWARE.
 'use strict';
 
-module.exports = function createHandler(ringpop) {
-    return function handle(arg1, arg2, hostInfo, callback) {
+module.exports = function createGossipHandler(ringpop) {
+    return function handleGossip(arg1, arg2, hostInfo, callback) {
         ringpop.gossip.start();
         callback(null, null, 'ok');
     };

diff --git a/server/admin/join.js b/server/admin/join.js
@@ -22,8 +22,8 @@
 var errors = require('../../lib/errors.js');
 var sendJoin = require('../../lib/swim/join-sender.js').joinCluster;
 
-module.exports = function createHandler(ringpop) {
-    return function handle(arg1, arg2, hostInfo, callback) {
+module.exports = function createJoinHandler(ringpop) {
+    return function handleJoin(arg1, arg2, hostInfo, callback) {
         if (!ringpop.membership.localMember) {
             process.nextTick(function() {
                 callback(errors.InvalidLocalMemberError());

diff --git a/server/admin/leave.js b/server/admin/leave.js
@@ -27,8 +27,8 @@ var RedundantLeaveError = TypedError({
     message: 'A node cannot leave its cluster when it has already left.'
 });
 
-module.exports = function createHandler(ringpop) {
-    return function handle(arg1, arg2, hostInfo, callback) {
+module.exports = function createLeaveHandler(ringpop) {
+    return function handleLeave(arg1, arg2, hostInfo, callback) {
         if (typeof callback !== 'function') {
             callback = function noop() {};
         }

diff --git a/server/admin/lookup.js b/server/admin/lookup.js
@@ -19,8 +19,8 @@
 // THE SOFTWARE.
 'use strict';
 
-module.exports = function createHandler(ringpop) {
-    return function handle(arg1, arg2, hostInfo, callback) {
+module.exports = function createLookupHandler(ringpop) {
+    return function handleLookup(arg1, arg2, hostInfo, callback) {
         var key = arg2.toString();
         callback(null, null, JSON.stringify({
             dest: ringpop.lookup(key)

diff --git a/server/admin/reload.js b/server/admin/reload.js
@@ -21,8 +21,8 @@
 
 var safeParse = require('../../lib/util.js').safeParse;
 
-module.exports = function createHandler(ringpop) {
-    return function handle(arg1, arg2, hostInfo, callback) {
+module.exports = function createReloadHandler(ringpop) {
+    return function handleReload(arg1, arg2, hostInfo, callback) {
         var body = safeParse(arg2.toString());
         if (body && body.file) {
             ringpop.reload(body.file, function(err) {

diff --git a/server/admin/stats.js b/server/admin/stats.js
@@ -19,8 +19,8 @@
 // THE SOFTWARE.
 'use strict';
 
-module.exports = function createHandler(ringpop) {
-    return function handle(arg1, arg2, hostInfo, callback) {
+module.exports = function createStatsHandler(ringpop) {
+    return function handleStats(arg1, arg2, hostInfo, callback) {
         callback(null, null, JSON.stringify(ringpop.getStats()));
     };
 };
diff --git a/server/admin/tick.js b/server/admin/tick.js
@@ -19,8 +19,8 @@
 // THE SOFTWARE.
 'use strict';
 
-module.exports = function createHandler(ringpop) {
-    return function handle(arg1, arg2, hostInfo, callback) {
+module.exports = function createTickHandler(ringpop) {
+    return function handleTick(arg1, arg2, hostInfo, callback) {
         ringpop.handleTick(function onTick(err, resp) {
             callback(err, null, JSON.stringify(resp));
         });