Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make wasm_bindgen optional #38

Merged
merged 2 commits into from
Aug 31, 2023
Merged

Make wasm_bindgen optional #38

merged 2 commits into from
Aug 31, 2023

Conversation

EpicEricEE
Copy link
Contributor

Closes #37

I hope I didn't miss anything. If you want to have the feature enabled by default, feel free to edit :)

erwanvivien
erwanvivien reviewed Aug 29, 2023
View reviewed changes
Copy link
Owner

@erwanvivien erwanvivien left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can I add missing changes to the PR directly?
Rust code works, only need to fix the "ci" & build scripts

Edit: I'll come back to this PR tomorrow

src/convert/mod.rs Outdated Show resolved Hide resolved
@EpicEricEE
Copy link
Contributor Author

Sure, just commit whatever is missing

@erwanvivien erwanvivien merged commit 33a38b0 into erwanvivien:master Aug 31, 2023
@erwanvivien
Copy link
Owner

Hey @EpicEricEE and @astrale-sharp,
I've updated fast_qr on crates.io, version is now 0.10.2

@astrale-sharp
Copy link

astrale-sharp commented Aug 31, 2023 •
edited
Loading

Nice! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erwanvivien erwanvivien erwanvivien left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

wasm-bindgen feature
3 participants
@EpicEricEE @erwanvivien @astrale-sharp