Fix bug when trying to get density #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #28 +/- ##
=======================================
Coverage 50.94% 50.94%
=======================================
Files 13 13
Lines 585 585
=======================================
Hits 298 298
Misses 287 287
Continue to review full report at Codecov.
|
erwanp
requested changes
Jan 31, 2022
qtplaskin/modeldata.py
Outdated
| @@ -483,7 +483,7 @@ def _index(s): | |||
| latest_i = min(d.shape[0] for d in | |||
| (self.raw_density, self.raw_rates, self.raw_conditions)) | |||
|
|
|||
| if isinstance(species, list): | |||
| if isinstance(species, str): | |||
| return self.raw_density[:latest_i, _index(species)] | |||
There was a problem hiding this comment.
@pag1pag i think it should be
# at the beginning of the function :
if isinstance(species, list):
return [self.raw_density[:latest_i, _index(s)] for s in species]
return self.raw_density[:latest_i, _index(species)]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using d.get("CH4") or d.get(["CH4"]), it was not working.
By changing
isinstance(xx, list)toisinstance(xx, str), it works.